Skip to content

chore: Rename "start" to "server" #1110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 23, 2022
Merged

chore: Rename "start" to "server" #1110

merged 1 commit into from
Apr 23, 2022

Conversation

kylecarbs
Copy link
Member

Workspace commands will be aliased at the top-level, so
"start" would easily be confused with starting a workspace.

Server seems like a more appropriate name too.

@kylecarbs kylecarbs requested review from f0ssel and bpmct April 23, 2022 16:04
@kylecarbs kylecarbs self-assigned this Apr 23, 2022
@codecov
Copy link

codecov bot commented Apr 23, 2022 •
edited
Loading

Codecov Report

Merging #1110 (265fb7b) into main (da36812) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1110      +/-   ##
==========================================
- Coverage   66.58%   66.58%   -0.01%     
==========================================
  Files         255      255              
  Lines       15743    15743              
  Branches      152      152              
==========================================
- Hits        10483    10482       -1     
- Misses       4190     4195       +5     
+ Partials     1070     1066       -4
Flag Coverage Δ
unittest-go-macos-latest 53.39% <100.00%> (+0.01%) ⬆️
unittest-go-postgres- 65.90% <100.00%> (-0.03%) ⬇️
unittest-go-ubuntu-latest 56.04% <100.00%> (+0.02%) ⬆️
unittest-go-windows-2022 52.92% <100.00%> (+0.02%) ⬆️
unittest-js 66.83% <ø> (ø)
Impacted Files Coverage Δ
cli/root.go 77.27% <100.00%> (ø)
cli/server.go 62.04% <100.00%> (ø)
provisioner/echo/serve.go 56.80% <0.00%> (-2.41%) ⬇️
provisionerd/provisionerd.go 79.85% <0.00%> (-1.33%) ⬇️
coderd/provisionerdaemons.go 60.37% <0.00%> (ø)
peer/conn.go 79.44% <0.00%> (+0.25%) ⬆️
provisioner/terraform/provision.go 71.39% <0.00%> (+0.43%) ⬆️
codersdk/provisionerdaemons.go 65.67% <0.00%> (+2.98%) ⬆️
cli/cliui/agent.go 82.45% <0.00%> (+5.26%) ⬆️
provisionersdk/transport.go 85.10% <0.00%> (+6.38%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update da36812...265fb7b. Read the comment docs.

@kylecarbs kylecarbs requested a review from a team as a code owner April 23, 2022 16:51
@kylecarbs kylecarbs requested review from coadler and removed request for a team and f0ssel April 23, 2022 16:51
@kylecarbs
chore: Rename "start" to "server"
265fb7b 
Workspace commands will be aliased at the top-level, so
"start" would easily be confused with starting a workspace.

Server seems like a more appropriate name too.
@kylecarbs kylecarbs merged commit 3976994 into main Apr 23, 2022
@kylecarbs kylecarbs deleted the mvstart branch April 23, 2022 17:19
kylecarbs added a commit that referenced this pull request Apr 23, 2022
@kylecarbs
chore: Rename "start" to "server" (#1110)
da8e511 
Workspace commands will be aliased at the top-level, so
"start" would easily be confused with starting a workspace.

Server seems like a more appropriate name too.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coadler coadler coadler approved these changes

@bpmct bpmct Awaiting requested review from bpmct

Assignees

@kylecarbs kylecarbs

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kylecarbs @coadler