Skip to content

fix(site): hide ws proxy on menu when disabled #11101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 8, 2023
Merged

fix(site): hide ws proxy on menu when disabled #11101

merged 2 commits into from
Dec 8, 2023

Conversation

BrunoQuaresma
Copy link
Collaborator

No description provided.

@BrunoQuaresma BrunoQuaresma self-assigned this Dec 8, 2023
cdr-bot[bot]
cdr-bot bot previously approved these changes Dec 8, 2023
View reviewed changes
Copy link

@cdr-bot cdr-bot bot left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is no longer a hotfix.

  • ✅ Base is main
  • ✅ Has hotfix label
  • ✅ Head is from coder/coder
  • ❌ Less than 100 lines

Parkreiner
Parkreiner approved these changes Dec 8, 2023
View reviewed changes
Copy link
Member

@Parkreiner Parkreiner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@BrunoQuaresma BrunoQuaresma changed the title fix(site): do not show ws proxy on menu if it is not enabled fix(site): hide ws proxy on menu when disabled Dec 8, 2023
@cdr-bot cdr-bot bot dismissed their stale review December 8, 2023 14:31

This PR is no longer a hotfix.

@BrunoQuaresma BrunoQuaresma merged commit 1f7c63c into main Dec 8, 2023
@BrunoQuaresma BrunoQuaresma deleted the bq/fix-ws-proxy-on-health branch December 8, 2023 14:47
@github-actions github-actions bot locked and limited conversation to collaborators Dec 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Parkreiner Parkreiner Parkreiner approved these changes

@cdr-bot cdr-bot[bot] cdr-bot[bot] left review comments

Assignees

@BrunoQuaresma BrunoQuaresma

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BrunoQuaresma @Parkreiner