Skip to content

docs: add license and template insights prom metrics #11109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 8, 2023
Merged

docs: add license and template insights prom metrics #11109

merged 2 commits into from
Dec 8, 2023

Conversation

ericpaulsen
Copy link
Member

this PR adds documentation for the following Prometheus metrics that were recently implemented:

coderd_insights_applications_usage_seconds
coderd_insights_parameters
coderd_insights_templates_active_users
coderd_license_active_users
coderd_license_limit_users
coderd_license_user_limit_enabled

@ericpaulsen ericpaulsen added the docs Area: coder.com/docs label Dec 8, 2023
@ericpaulsen ericpaulsen requested review from coadler and mtojek December 8, 2023 19:02
@ericpaulsen ericpaulsen self-assigned this Dec 8, 2023
@ericpaulsen ericpaulsen requested a review from matifali December 8, 2023 19:06
matifali
matifali approved these changes Dec 8, 2023
View reviewed changes
Copy link
Member

@matifali matifali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aren't these auto generated docs?

matifali
matifali reviewed Dec 8, 2023
View reviewed changes
Copy link
Member

@matifali matifali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

aren't these auto generated docs? they should be auto generated whenever we add any new matrics.

@matifali reviewed this PR from Slack with Graphite

@ericpaulsen
Copy link
Member Author

@matifali they are auto-generated from the scripts/metricsdocgen/metrics file. we do not auto-append newly added metrics to this file, however. it required a manual update.

@ericpaulsen ericpaulsen merged commit 167c759 into main Dec 8, 2023
@ericpaulsen ericpaulsen deleted the missing-prom-metrics branch December 8, 2023 19:17
@github-actions github-actions bot locked and limited conversation to collaborators Dec 8, 2023
@matifali Graphite App
Copy link
Member

matifali commented Dec 8, 2023

Is thera a reason why we do not make it automated as part of make gen ?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@matifali matifali matifali approved these changes

@coadler coadler Awaiting requested review from coadler

@mtojek mtojek Awaiting requested review from mtojek

Assignees

@ericpaulsen ericpaulsen

Labels
docs Area: coder.com/docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ericpaulsen @matifali