Skip to content

fix: provide helpful error when no login url specified #11110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 8, 2023
Merged

fix: provide helpful error when no login url specified #11110

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
fix: provide helpful error when no login url specified
  • Loading branch information
@f0ssel
f0ssel committed Dec 8, 2023
commit 351b848269f3b6da680a1ef39a7d75d732050d8a
4 changes: 4 additions & 0 deletions cli/login.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,6 +147,10 @@ func (r *RootCmd) login() *clibase.Cmd {
rawURL = inv.Args[0]
}

if rawURL == "" {
return xerrors.Errorf("no url argument provided")
}

if !strings.HasPrefix(rawURL, "http://") && !strings.HasPrefix(rawURL, "https://") {
scheme := "https"
if strings.HasPrefix(rawURL, "localhost") {
Expand Down