Skip to content

fix: prevent editing build parameters if template requires active version #11117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Dec 11, 2023
Merged

fix: prevent editing build parameters if template requires active version #11117

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
036c2dc
fix: prevent editing build parameters if template requires active ver…
sreya Dec 10, 2023
31eaca6
typos
sreya Dec 10, 2023
cde38cf
use component alert
sreya Dec 10, 2023
b97f42e
only display if outdated
sreya Dec 10, 2023
e5af124
add storybook
sreya Dec 10, 2023
d756a6f
move `Alert`
aslilac Dec 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
typos
  • Loading branch information
@sreya
sreya committed Dec 10, 2023
commit 31eaca6653f7e43ed318ee1831d27fb39c30c6a7
4 changes: 3 additions & 1 deletion site/src/pages/WorkspaceSettingsPage/WorkspaceParametersPage/WorkspaceParametersForm.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,9 @@ export const WorkspaceParametersForm: FC<{
);

const disabled =
workspace.template_require_active_version && !canChangeVersions;
workspace.outdated &&
workspace.template_require_active_version &&
!canChangeVersions;

return (
<HorizontalForm onSubmit={form.handleSubmit} data-testid="form">
Expand Down
4 changes: 2 additions & 2 deletions site/src/pages/WorkspaceSettingsPage/WorkspaceParametersPage/WorkspaceParametersPage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,8 +124,8 @@ export const WorkspaceParametersPageView: FC<

{workspace.template_require_active_version && !canChangeVersions && (
<Alert severity="warning" css={{ marginBottom: 48 }}>
The template for this workspace requires automatic updates. This
workspace must be on the latest version to edit paremeters.
The template for this workspace requires automatic updates. Update the
workspace to edit parameters.
</Alert>
)}

Expand Down