Skip to content

feat: add metrics to workspace agent scripts #11132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 19 commits into from
Dec 13, 2023
Merged

feat: add metrics to workspace agent scripts #11132

Changes from 1 commit
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
2f978c3
wip: work on agent script metrics
Emyrk Dec 8, 2023
c567eab
push startup script metrics to agent
Emyrk Dec 11, 2023
5d39495
Add metrics pushing to prometheus
Emyrk Dec 11, 2023
07fe74a
make metric a normal prom metric exported, rather than a first class
Emyrk Dec 11, 2023
753f1a6
linting/fmt/naming
Emyrk Dec 11, 2023
aafd29e
add template_name label to workspace agent stats
Emyrk Dec 11, 2023
6c5a560
Fix prom tests
Emyrk Dec 11, 2023
ad3f47f
Update prom docs
Emyrk Dec 11, 2023
19428fa
seed template id in test
Emyrk Dec 11, 2023
8bfa9ad
fixup! seed template id in test
Emyrk Dec 12, 2023
044b942
PR feedback, _s -> seconds, start -> startup
Emyrk Dec 13, 2023
2db41b6
change string params to a struct
Emyrk Dec 13, 2023
dd32401
Change the name of the labels argument struct
Emyrk Dec 13, 2023
b4a3607
Clarify comment
Emyrk Dec 13, 2023
c5da250
Remove extra words
Emyrk Dec 13, 2023
eb1d173
measure workspace startup closer to script finish in lines of code
Emyrk Dec 13, 2023
e803436
Fix unit test call args
Emyrk Dec 13, 2023
99483fe
Make gen
Emyrk Dec 13, 2023
2f89b62
Formatting
Emyrk Dec 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
measure workspace startup closer to script finish in lines of code
  • Loading branch information
@Emyrk
Emyrk committed Dec 13, 2023
commit eb1d173bd2a7eb394ef65f559f80eecff6a70301
3 changes: 2 additions & 1 deletion agent/agent.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -755,6 +755,8 @@ func (a *agent) run(ctx context.Context) error {
err := a.scriptRunner.Execute(ctx, func(script codersdk.WorkspaceAgentScript) bool {
return script.RunOnStart
})
// Measure the time immediately after the script has finished
dur := time.Since(start).Seconds()
if err != nil {
a.logger.Warn(ctx, "startup script(s) failed", slog.Error(err))
if errors.Is(err, agentscripts.ErrTimeout) {
Expand All @@ -766,7 +768,6 @@ func (a *agent) run(ctx context.Context) error {
a.setLifecycle(ctx, codersdk.WorkspaceAgentLifecycleReady)
}

dur := time.Since(start).Seconds()
label := "false"
if err == nil {
label = "true"
Expand Down