Skip to content

test: insights metrics: verify plugin usage #11156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 13, 2023
Merged

test: insights metrics: verify plugin usage #11156

merged 3 commits into from
Dec 13, 2023

Conversation

mtojek
Copy link
Member

@mtojek mtojek commented Dec 12, 2023 •
edited
Loading

Related: #11103

Make sure that MetricsCollector collects and exposes Prometheus metrics for JetBrains and VS Code plugins.

@mtojek mtojek changed the title test: insights metrics: verify jetbrains usage test: insights metrics: verify plugin usage Dec 12, 2023
@mtojek mtojek requested a review from mafredri December 12, 2023 14:37
@mtojek mtojek marked this pull request as ready for review December 12, 2023 14:37
mafredri
mafredri approved these changes Dec 13, 2023
View reviewed changes
Copy link
Member

@mafredri mafredri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, good to have a test case for this as well 👍

@mtojek mtojek merged commit ef4d1b6 into main Dec 13, 2023
@mtojek mtojek deleted the 11103-jetbrains branch December 13, 2023 09:46
@github-actions github-actions bot locked and limited conversation to collaborators Dec 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mafredri mafredri mafredri approved these changes

Assignees

@mtojek mtojek

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mtojek @mafredri