fix: Add resiliency to daemon connections #1116
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1116 +/- ##
==========================================
- Coverage 66.61% 66.57% -0.04%
==========================================
Files 257 257
Lines 16011 16082 +71
Branches 156 156
==========================================
+ Hits 10665 10707 +42
- Misses 4266 4280 +14
- Partials 1080 1095 +15
Continue to review full report at Codecov.
|
coadler
approved these changes
Apr 24, 2022
provisionersdk/transport.go
Outdated
| // TransportPipe creates an in-memory pipe for dRPC transport. | ||
| func TransportPipe() (*yamux.Session, *yamux.Session) { | ||
| clientReader, clientWriter := io.Pipe() | ||
| serverReader, serverWriter := io.Pipe() | ||
| yamuxConfig := yamux.DefaultConfig() | ||
| yamuxConfig.LogOutput = io.Discard | ||
| yamuxConfig.LogOutput = os.Stderr |
There was a problem hiding this comment.
Was this turned on for debugging?
| t.Run("PayloadTooBig", func(t *testing.T) { | ||
| t.Parallel() | ||
| if runtime.GOOS == "windows" { | ||
| // Takes too long to allocate memory on Windows! |
5fb7b25 to
b401270
Compare
Connections could fail when massive payloads were transmitted. This fixes an upstream bug in dRPC where the connection would end with a context canceled if a message was too large. This adds retransmission of completion and failures too. If Coder somehow loses connection with a provisioner daemon, upon the next connection the state will be properly reported.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connections could fail when massive payloads were transmitted.
This fixes an upstream bug in dRPC where the connection would
end with a context canceled if a message was too large.
This adds retransmission of completion and failures too. If
Coder somehow loses connection with a provisioner daemon,
upon the next connection the state will be properly reported.