Skip to content

chore: validate queries using sqlc-vet in github actions #11163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Dec 12, 2023
Merged

chore: validate queries using sqlc-vet in github actions #11163

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
1ea18a6
chore: add sqlc-vet to github actions for validating queries
Emyrk Dec 12, 2023
845794b
fmt
Emyrk Dec 12, 2023
6ac0302
Trying some different deps
Emyrk Dec 12, 2023
93ef5f0
Only run sqlc-vet when required by changes
Emyrk Dec 12, 2023
3c4a818
require sqlc-vet
Emyrk Dec 12, 2023
2dd66a9
print a success message on vet
Emyrk Dec 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Only run sqlc-vet when required by changes
  • Loading branch information
@Emyrk
Emyrk committed Dec 12, 2023
commit 93ef5f0a6ecb97174de22b19e0f6eb8cde33423f
12 changes: 9 additions & 3 deletions .github/workflows/ci.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@ jobs:
ts: ${{ steps.filter.outputs.ts }}
k8s: ${{ steps.filter.outputs.k8s }}
ci: ${{ steps.filter.outputs.ci }}
db: ${{ steps.filter.outputs.db }}
offlinedocs-only: ${{ steps.filter.outputs.offlinedocs_count == steps.filter.outputs.all_count }}
offlinedocs: ${{ steps.filter.outputs.offlinedocs }}
steps:
Expand All @@ -57,6 +58,12 @@ jobs:
- "examples/web-server/**"
- "examples/monitoring/**"
- "examples/lima/**"
db:
- "**.sql"
- "coderd/database/queries/**"
- "coderd/database/migrations"
- "coderd/database/sqlc.yaml"
- "coderd/database/dump.sql"
go:
- "**.sql"
- "**.go"
Expand Down Expand Up @@ -315,7 +322,7 @@ jobs:

test-go-pg:
runs-on: ${{ github.repository_owner == 'coder' && 'buildjet-8vcpu-ubuntu-2204' || 'ubuntu-latest' }}
needs: sqlc-vet
needs: changes
if: needs.changes.outputs.go == 'true' || needs.changes.outputs.ci == 'true' || github.ref == 'refs/heads/main'
# This timeout must be greater than the timeout set by `go test` in
# `make test-postgres` to ensure we receive a trace of running
Expand Down Expand Up @@ -915,8 +922,7 @@ jobs:
sqlc-vet:
runs-on: ${{ github.repository_owner == 'coder' && 'buildjet-8vcpu-ubuntu-2204' || 'ubuntu-latest' }}
needs: changes
# TODO: We should do this on any migration or query changes.
# if: needs.changes.outputs.go == 'true' || needs.changes.outputs.ci == 'true' || github.ref == 'refs/heads/main'
if: needs.changes.outputs.db == 'true' || github.ref == 'refs/heads/main'
steps:
- name: Checkout
uses: actions/checkout@v4
Expand Down