chore: bump go (->v1.21.5) and sqlc (->v1.24.0) to new versions #11170
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding support for sqlc vet made sqlc gen require a db connection. Disable that to get previous behavior
|
This is no longer a hotfix.
|
Emyrk
commented
Dec 12, 2023
| @@ -53,7 +53,7 @@ RUN mkdir --parents "$GOPATH" && \ | |||
| # charts and values files | |||
| go install github.com/norwoodj/helm-docs/cmd/helm-docs@v1.5.0 && \ | |||
| # sqlc for Go code generation | |||
| go install github.com/sqlc-dev/sqlc/cmd/sqlc@v1.20.0 && \ | |||
| (CGO_ENABLED=1 go install github.com/sqlc-dev/sqlc/cmd/sqlc@v1.24.0) && \ | |||
There was a problem hiding this comment.
This is annoying, but the postgres engine requires CGO. This is compiling a utility binary, so it doesn't push any CGO into coder.
coadler
approved these changes
Dec 13, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional
Bump sqlc to 1.24.0
Adding support for sqlc vet made sqlc gen require a db connection. Disable that to get previous behavior