Skip to content

Conversation

Emyrk
Copy link
Member

@Emyrk Emyrk commented Dec 12, 2023

Begin pushing our schemas to sqlc cloud on all releases.

This will allow us to run sqlc verify when creating a new release or on regular commits.

Warns

  • Indicate queries that are do seq scans (this will warn not fail)
  • Nullable columns
  • Tables without primary keys

It can also detect if previous queries are not forward compatible, meaning a blue/green deployment will fail.

I am not going to run sqlc verify at this time in CI.

@Emyrk Emyrk changed the title add sqlc push action on releases chore: add sqlc push action on releases Dec 12, 2023
Base automatically changed from stevenmasley/local-make-gen to main December 13, 2023 00:50
@Emyrk Emyrk force-pushed the stevenmasley/sqlc-verify branch from be7a191 to 08803ee Compare December 13, 2023 19:07
@Emyrk Emyrk marked this pull request as ready for review December 13, 2023 21:32
@Emyrk Emyrk requested a review from coadler December 15, 2023 15:44
@Emyrk Emyrk force-pushed the stevenmasley/sqlc-verify branch from 30d89bd to 76c9309 Compare December 15, 2023 15:45
@Emyrk Emyrk force-pushed the stevenmasley/sqlc-verify branch from 76c9309 to a0df2f9 Compare December 19, 2023 20:25
@Emyrk Emyrk enabled auto-merge (squash) December 19, 2023 20:25
@Emyrk Emyrk merged commit e8be092 into main Dec 19, 2023
@Emyrk Emyrk deleted the stevenmasley/sqlc-verify branch December 19, 2023 20:31
@github-actions github-actions bot locked and limited conversation to collaborators Dec 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants