Skip to content

fix: Monitor TTY size when using SSH #1119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 25, 2022
Merged

fix: Monitor TTY size when using SSH #1119

merged 1 commit into from
Apr 25, 2022

Conversation

kylecarbs
Copy link
Member

The TTY wasn't resizing properly, and reasonably so considering
we weren't updating it 🤦.

@kylecarbs kylecarbs requested a review from coadler April 25, 2022 02:38
@kylecarbs kylecarbs self-assigned this Apr 25, 2022
@codecov
Copy link

codecov bot commented Apr 25, 2022

Codecov Report

Merging #1119 (e1257c0) into main (23295f7) will decrease coverage by 0.06%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #1119      +/-   ##
==========================================
- Coverage   66.51%   66.44%   -0.07%     
==========================================
  Files         259      261       +2     
  Lines       16159    16188      +29     
  Branches      156      156              
==========================================
+ Hits        10748    10756       +8     
- Misses       4306     4328      +22     
+ Partials     1105     1104       -1     
Flag Coverage Δ
unittest-go-macos-latest 53.80% <0.00%> (-0.04%) ⬇️
unittest-go-postgres- 65.77% <0.00%> (-0.18%) ⬇️
unittest-go-ubuntu-latest 56.37% <0.00%> (+0.08%) ⬆️
unittest-go-windows-2022 53.24% <0.00%> (-0.08%) ⬇️
unittest-js 67.28% <ø> (ø)
Impacted Files Coverage Δ
cli/ssh.go 36.76% <0.00%> (-2.61%) ⬇️
cli/ssh_other.go 0.00% <0.00%> (ø)
cli/ssh_windows.go 0.00% <0.00%> (ø)
codersdk/provisionerdaemons.go 61.97% <0.00%> (-5.64%) ⬇️
cli/cliui/agent.go 77.19% <0.00%> (-5.27%) ⬇️
provisionerd/provisionerd.go 77.29% <0.00%> (-0.95%) ⬇️
provisioner/terraform/provision.go 70.96% <0.00%> (-0.44%) ⬇️
coderd/provisionerdaemons.go 63.29% <0.00%> (+1.01%) ⬆️
peer/channel.go 84.97% <0.00%> (+1.73%) ⬆️
provisioner/echo/serve.go 59.20% <0.00%> (+2.40%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 23295f7...e1257c0. Read the comment docs.

The TTY wasn't resizing properly, and reasonably so considering
we weren't updating it 🤦.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants