Add types to oauth2 stories

coder · code-asher · Dec 21, 2023 · Dec 11, 2023 · Dec 11, 2023 · Dec 12, 2023
commit 35978edc9597a487c25876743e8592514ab86883
diff --git a/site/src/pages/DeploySettingsPage/OAuth2AppsSettingsPage/CreateOAuth2AppPageView.stories.tsx b/site/src/pages/DeploySettingsPage/OAuth2AppsSettingsPage/CreateOAuth2AppPageView.stories.tsx
@@ -1,18 +1,21 @@
-import { CreateOAuth2AppPageView } from "./CreateOAuth2AppPageView";
+import type { StoryObj } from "@storybook/react";
 import { mockApiError } from "testHelpers/entities";
+import { CreateOAuth2AppPageView } from "./CreateOAuth2AppPageView";
 
 export default {
   title: "pages/DeploySettingsPage/CreateOAuth2AppPageView",
   component: CreateOAuth2AppPageView,
 };
 
-export const Updating = {
+type Story = StoryObj<typeof CreateOAuth2AppPageView>;
+
+export const Updating: Story = {
   args: {
     isUpdating: true,
   },
 };
 
-export const Error = {
+export const Error: Story = {
   args: {
     error: mockApiError({
       message: "Validation failed",
@@ -34,7 +37,7 @@ export const Error = {
   },
 };
 
-export const Default = {
+export const Default: Story = {
   args: {
     // Nothing.
   },

diff --git a/site/src/pages/DeploySettingsPage/OAuth2AppsSettingsPage/EditOAuth2AppPageView.stories.tsx b/site/src/pages/DeploySettingsPage/OAuth2AppsSettingsPage/EditOAuth2AppPageView.stories.tsx
@@ -1,29 +1,32 @@
-import { EditOAuth2AppPageView } from "./EditOAuth2AppPageView";
+import type { StoryObj } from "@storybook/react";
 import {
   MockOAuth2Apps,
   MockOAuth2AppSecrets,
   mockApiError,
 } from "testHelpers/entities";
+import { EditOAuth2AppPageView } from "./EditOAuth2AppPageView";
 
 export default {
   title: "pages/DeploySettingsPage/EditOAuth2AppPageView",
   component: EditOAuth2AppPageView,
 };
 
-export const LoadingApp = {
+type Story = StoryObj<typeof EditOAuth2AppPageView>;
+
+export const LoadingApp: Story = {
   args: {
     isLoadingApp: true,
   },
 };
 
-export const LoadingSecrets = {
+export const LoadingSecrets: Story = {
   args: {
     app: MockOAuth2Apps[0],
     isLoadingSecrets: true,
   },
 };
 
-export const Error = {
+export const Error: Story = {
   args: {
     app: MockOAuth2Apps[0],
     secrets: MockOAuth2AppSecrets,
@@ -47,7 +50,7 @@ export const Error = {
   },
 };
 
-export const Default = {
+export const Default: Story = {
   args: {
     app: MockOAuth2Apps[0],
     secrets: MockOAuth2AppSecrets,

diff --git a/...rc/pages/DeploySettingsPage/OAuth2AppsSettingsPage/OAuth2AppsSettingsPageView.stories.tsx b/...rc/pages/DeploySettingsPage/OAuth2AppsSettingsPage/OAuth2AppsSettingsPageView.stories.tsx
@@ -1,35 +1,37 @@
-import OAuth2AppsSettingsPageView from "./OAuth2AppsSettingsPageView";
+import type { StoryObj } from "@storybook/react";
 import { MockOAuth2Apps } from "testHelpers/entities";
+import OAuth2AppsSettingsPageView from "./OAuth2AppsSettingsPageView";
 
 export default {
   title: "pages/DeploySettingsPage/OAuth2AppsSettingsPageView",
   component: OAuth2AppsSettingsPageView,
 };
 
-export const Loading = {
+type Story = StoryObj<typeof OAuth2AppsSettingsPageView>;
+
+export const Loading: Story = {
   args: {
     isLoading: true,
   },
 };
 
-export const Unentitled = {
+export const Unentitled: Story = {
   args: {
     isLoading: false,
     apps: MockOAuth2Apps,
   },
 };
 
-export const Entitled = {
+export const Entitled: Story = {
   args: {
     isLoading: false,
     apps: MockOAuth2Apps,
     isEntitled: true,
   },
 };
 
-export const Empty = {
+export const Empty: Story = {
   args: {
     isLoading: false,
-    apps: null,
   },
 };