fix: Remove unique index on auth tokens #1120
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1120 +/- ##
==========================================
+ Coverage 66.54% 66.58% +0.04%
==========================================
Files 259 259
Lines 16159 16159
Branches 156 156
==========================================
+ Hits 10753 10760 +7
+ Misses 4301 4295 -6
+ Partials 1105 1104 -1
Continue to review full report at Codecov.
|
If a workspace is started multiple times, resources may not be invalidated. This means an auth token can be reused for a workspace. coderd closes old agent connections, so this is expected behavior, and the agent will reconnect properly.
coadler
approved these changes
Apr 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a workspace is started multiple times, resources may
not be invalidated. This means an auth token can be
reused for a workspace.
coderd closes old agent connections, so this is expected
behavior and the agent will reconnect properly.