Skip to content

fix: prevent data race when mutating tags #11200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 14, 2023
Merged

fix: prevent data race when mutating tags #11200

merged 1 commit into from
Dec 14, 2023

Conversation

sreya
Copy link
Collaborator

@sreya sreya commented Dec 14, 2023 •
edited
Loading

This can really only happen in our in-memory database implementation. The tests can also be improved by isolating templates to each subtest but this is probably a good fix anyway since the signature of the function suggests a different map is being returned.

fixes #11190

@sreya sreya requested a review from johnstcn December 14, 2023 03:56
johnstcn
johnstcn approved these changes Dec 14, 2023
View reviewed changes
Copy link
Member

@johnstcn johnstcn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch! I do think that the function name and signature are slightly at odds now though, but that's an issue for a separate PR. 👍

@johnstcn johnstcn merged commit 82f7b0c into main Dec 14, 2023
@johnstcn johnstcn deleted the jon/fixclirace branch December 14, 2023 08:57
@github-actions github-actions bot locked and limited conversation to collaborators Dec 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@johnstcn johnstcn johnstcn approved these changes

Assignees

@sreya sreya

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

flake: TestStart
2 participants
@sreya @johnstcn