Skip to content

ci: fix syntax for ipv6 address in fly.io wsproxies #11205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 14, 2023
Merged

ci: fix syntax for ipv6 address in fly.io wsproxies #11205

merged 3 commits into from
Dec 14, 2023

Conversation

matifali
Copy link
Member

@matifali matifali commented Dec 14, 2023 •
edited
Loading

If the IP address is an ipv6 address, we need to use square brackets [].

@matifali matifali self-assigned this Dec 14, 2023
@matifali matifali marked this pull request as ready for review December 14, 2023 12:18
@matifali matifali merged commit b779655 into main Dec 14, 2023
@matifali matifali deleted the matifali-patch-1 branch December 14, 2023 12:26
@github-actions github-actions bot locked and limited conversation to collaborators Dec 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@deansheather deansheather deansheather approved these changes

Assignees

@matifali matifali

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@matifali @deansheather