fix: copy StringMap on insert and query in dbmem #11206
Conversation
|
Current dependencies on/for this PR: This stack of pull requests is managed by Graphite. |
There was a problem hiding this comment.
Thorough! 💪🏻
For the future, I wonder if it would make sense to add a marshal/unmarshal step to the return values of all methods. This should hopefully always work since a similar thing happens in the real DB layer. Adds overhead/makes this a bit slower, but should avoid the issue that prompted this change.
|
I hit this exact thing awhile back. I made an issue I never got around too: #6680 A marshal would solve it, just annoying to do on every function 😢 |
We should be able to code gen it. Named args and a defer at the top. |
We need to document all our current code gen. Would be awesome if we had some standard framework for our code gens to all work under. |
Addresses the issue in #11185 for the StringMap datatype.
There are other slice data types in our database package that also need to be fixed, but that'll be a different PR