Skip to content

fix: tar: do not archive .tfvars #11208

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 15, 2023
Merged

fix: tar: do not archive .tfvars #11208

merged 2 commits into from
Dec 15, 2023

Conversation

mtojek
Copy link
Member

@mtojek mtojek commented Dec 14, 2023 •
edited
Loading

Related: #8501

First baby step to correctly handle .tfvars in Coder. This PR prevents provisionersdk.Tar archiving all variations of .tfvars files.

@mtojek mtojek self-assigned this Dec 14, 2023
@mtojek mtojek mentioned this pull request Dec 14, 2023
Closed
@mtojek mtojek marked this pull request as ready for review December 14, 2023 13:14
@mtojek mtojek requested a review from johnstcn December 14, 2023 13:14
johnstcn
johnstcn approved these changes Dec 14, 2023
View reviewed changes
@mtojek mtojek requested a review from johnstcn December 15, 2023 10:14
@mtojek
Copy link
Member Author

mtojek commented Dec 15, 2023

Re-requesting review as the PR size increased.

@mtojek mtojek merged commit 89d8a29 into main Dec 15, 2023
@mtojek mtojek deleted the 8501-parse-tfvars branch December 15, 2023 10:15
@github-actions github-actions bot locked and limited conversation to collaborators Dec 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@johnstcn johnstcn johnstcn approved these changes

Assignees

@mtojek mtojek

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mtojek @johnstcn