Skip to content

fix: use fmt.Fprintln to print workspaces table #1122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 25, 2022
Merged

Conversation

coadler
Copy link
Contributor

@coadler coadler commented Apr 25, 2022

It was missing a newline

@coadler coadler self-assigned this Apr 25, 2022
@coadler coadler requested a review from kylecarbs April 25, 2022 03:48
@coadler coadler enabled auto-merge (squash) April 25, 2022 03:49
@codecov
Copy link

codecov bot commented Apr 25, 2022

Codecov Report

Merging #1122 (6d96ef3) into main (a6ea995) will decrease coverage by 8.99%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #1122      +/-   ##
==========================================
- Coverage   66.51%   57.52%   -9.00%     
==========================================
  Files         261      261              
  Lines       16194    16194              
  Branches      156      156              
==========================================
- Hits        10772     9316    -1456     
- Misses       4319     5859    +1540     
+ Partials     1103     1019      -84     
Flag Coverage Δ
unittest-go-macos-latest 53.62% <0.00%> (-0.11%) ⬇️
unittest-go-postgres- ?
unittest-go-ubuntu-latest 56.36% <0.00%> (+0.01%) ⬆️
unittest-go-windows-2022 53.22% <0.00%> (-0.03%) ⬇️
unittest-js 67.28% <ø> (ø)
Impacted Files Coverage Δ
cli/workspacelist.go 7.01% <0.00%> (ø)
coderd/database/queries.sql.go 0.00% <0.00%> (-81.80%) ⬇️
coderd/devtunnel/tunnel.go 0.00% <0.00%> (-79.67%) ⬇️
coderd/database/pubsub.go 0.00% <0.00%> (-77.78%) ⬇️
coderd/database/db.go 0.00% <0.00%> (-55.18%) ⬇️
coderd/database/migrate.go 0.00% <0.00%> (-45.00%) ⬇️
pty/start_other.go 64.70% <0.00%> (-23.53%) ⬇️
provisionersdk/serve.go 35.13% <0.00%> (-8.11%) ⬇️
codersdk/provisionerdaemons.go 61.97% <0.00%> (-5.64%) ⬇️
coderd/workspaceagents.go 58.51% <0.00%> (-5.56%) ⬇️
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a6ea995...6d96ef3. Read the comment docs.

@coadler coadler merged commit abc13c5 into main Apr 25, 2022
@coadler coadler deleted the colin/wksp-list-table branch April 25, 2022 04:04
@misskniss misskniss added this to the V2 Beta milestone May 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants