refactor(cli): load template variables #11234
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnstcn
approved these changes
Dec 15, 2023
| return nil, err | ||
| } | ||
|
|
||
| return combineVariableValues(fromFile, fromCommandLine), nil |
There was a problem hiding this comment.
This raises an interesting question - what should the order of precedence be between values from files and values specified directly by CLI?
My hunch is that CLI variables should override those specified in files, and looking at combineVariableValues below that seems to be what would happen here.
There was a problem hiding this comment.
My hunch is that CLI variables should override those specified in files, and looking at combineVariableValues below that seems to be what would happen here.
Yeah, that is my idea too. I described the order of precedence here.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: #8501
I need to refactor existing CLI logic to load template variables and prepare it for another source, local
tfvarsfiles.