Skip to content

fix: Add sync.Once to prevent double close in test #1124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 25, 2022
Merged

Conversation

kylecarbs
Copy link
Member

@kylecarbs kylecarbs requested a review from coadler April 25, 2022 03:59
@kylecarbs kylecarbs self-assigned this Apr 25, 2022
@kylecarbs kylecarbs enabled auto-merge (squash) April 25, 2022 04:00
@codecov
Copy link

codecov bot commented Apr 25, 2022

Codecov Report

Merging #1124 (78ac4df) into main (a6ea995) will decrease coverage by 0.13%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1124      +/-   ##
==========================================
- Coverage   66.51%   66.38%   -0.14%     
==========================================
  Files         261      261              
  Lines       16194    16194              
  Branches      156      156              
==========================================
- Hits        10772    10750      -22     
- Misses       4319     4337      +18     
- Partials     1103     1107       +4     
Flag Coverage Δ
unittest-go-macos-latest 53.77% <ø> (+0.04%) ⬆️
unittest-go-postgres- 65.73% <ø> (-0.20%) ⬇️
unittest-go-ubuntu-latest 56.29% <ø> (-0.06%) ⬇️
unittest-go-windows-2022 53.22% <ø> (-0.03%) ⬇️
unittest-js 67.28% <ø> (ø)
Impacted Files Coverage Δ
pty/start_other.go 64.70% <0.00%> (-23.53%) ⬇️
provisionersdk/serve.go 35.13% <0.00%> (-8.11%) ⬇️
peer/channel.go 83.23% <0.00%> (-2.32%) ⬇️
peer/conn.go 78.17% <0.00%> (-2.04%) ⬇️
coderd/workspaceagents.go 62.59% <0.00%> (-1.49%) ⬇️
coderd/provisionerdaemons.go 62.79% <0.00%> (-0.51%) ⬇️
provisionerd/provisionerd.go 76.67% <0.00%> (+0.26%) ⬆️
provisioner/echo/serve.go 61.60% <0.00%> (+4.80%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a6ea995...78ac4df. Read the comment docs.

@kylecarbs kylecarbs merged commit 68f67c5 into main Apr 25, 2022
@kylecarbs kylecarbs deleted the provflake branch April 25, 2022 04:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants