Skip to content

chore: fix flake, use time closer to actual test #11240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 18, 2023

Conversation

Emyrk
Copy link
Member

@Emyrk Emyrk commented Dec 15, 2023

The tests were queued, and the autostart time was being set to the time the table was created, not when the test was actually being run. This diff was causing failures in CI

Fixes: #11011

Could reproduce by adding a sleep to the start of the test

Copy link
Member

@johnstcn johnstcn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice find!

The tests were queued, and the autostart time was being set
to the time the table was created, not when the test was actually
being run. This diff was causing failures in CI
@Emyrk Emyrk force-pushed the stevenmasley/flake_ActivityBumpWorkspace branch from 87f0552 to 35bc999 Compare December 18, 2023 15:27
@Emyrk Emyrk merged commit c35b560 into main Dec 18, 2023
@Emyrk Emyrk deleted the stevenmasley/flake_ActivityBumpWorkspace branch December 18, 2023 16:55
@github-actions github-actions bot locked and limited conversation to collaborators Dec 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

flake: Test_ActivityBumpWorkspace
2 participants