Skip to content

refactor(site): make HelpTooltip easier to reuse and compose #11242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Dec 19, 2023
Merged

refactor(site): make HelpTooltip easier to reuse and compose #11242

merged 12 commits into from
Dec 19, 2023

Conversation

BrunoQuaresma
Copy link
Collaborator

No description provided.

@BrunoQuaresma BrunoQuaresma requested review from aslilac and a team December 15, 2023 19:14
@BrunoQuaresma BrunoQuaresma self-assigned this Dec 15, 2023
Parkreiner
Parkreiner approved these changes Dec 18, 2023
View reviewed changes
Copy link
Member

@Parkreiner Parkreiner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look great! Just had a few suggestions/questions

@Parkreiner
Copy link
Member

Also noticed a few visual regressions in the stories

@BrunoQuaresma
Copy link
Collaborator Author

Going to fix the stories right now!

@BrunoQuaresma BrunoQuaresma merged commit 7c4fbe5 into main Dec 19, 2023
@BrunoQuaresma BrunoQuaresma deleted the bq/refactor-help-tooltip branch December 19, 2023 13:43
@github-actions github-actions bot locked and limited conversation to collaborators Dec 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@aslilac aslilac aslilac left review comments

@Parkreiner Parkreiner Parkreiner approved these changes

Assignees

@BrunoQuaresma BrunoQuaresma

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@BrunoQuaresma @Parkreiner @aslilac