Skip to content

feat: Add links for registering git key #1125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 25, 2022
Merged

feat: Add links for registering git key #1125

merged 1 commit into from
Apr 25, 2022

Conversation

kylecarbs
Copy link
Member

image

@kylecarbs kylecarbs requested a review from coadler April 25, 2022 04:12
@kylecarbs kylecarbs self-assigned this Apr 25, 2022
@codecov
Copy link

codecov bot commented Apr 25, 2022 •
edited
Loading

Codecov Report

Merging #1125 (387a7db) into main (a6ea995) will decrease coverage by 0.13%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1125      +/-   ##
==========================================
- Coverage   66.51%   66.37%   -0.14%     
==========================================
  Files         261      257       -4     
  Lines       16194    16017     -177     
  Branches      156      156              
==========================================
- Hits        10772    10632     -140     
+ Misses       4319     4293      -26     
+ Partials     1103     1092      -11
Flag Coverage Δ
unittest-go-macos-latest 53.75% <100.00%> (+0.02%) ⬆️
unittest-go-postgres- 65.74% <100.00%> (-0.19%) ⬇️
unittest-go-ubuntu-latest 56.37% <100.00%> (+0.02%) ⬆️
unittest-go-windows-2022 ?
unittest-js 67.28% <ø> (ø)
Impacted Files Coverage Δ
cli/publickey.go 76.00% <100.00%> (+16.00%) ⬆️
pty/start_other.go 64.70% <0.00%> (-23.53%) ⬇️
cli/configssh.go 61.41% <0.00%> (-7.09%) ⬇️
codersdk/provisionerdaemons.go 61.97% <0.00%> (-5.64%) ⬇️
pty/ptytest/ptytest.go 89.65% <0.00%> (-5.18%) ⬇️
cli/templateinit.go 58.62% <0.00%> (-3.45%) ⬇️
coderd/workspaceagents.go 61.11% <0.00%> (-2.97%) ⬇️
cli/agent.go 80.00% <0.00%> (-2.18%) ⬇️
peer/channel.go 83.81% <0.00%> (-1.74%) ⬇️
cli/gitssh.go 52.94% <0.00%> (-1.41%) ⬇️
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a6ea995...387a7db. Read the comment docs.

@kylecarbs kylecarbs enabled auto-merge (squash) April 25, 2022 04:26
@kylecarbs kylecarbs merged commit c8e566f into main Apr 25, 2022
@kylecarbs kylecarbs deleted the pubkeyoutput branch April 25, 2022 04:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coadler coadler coadler approved these changes

Assignees

@kylecarbs kylecarbs

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kylecarbs @coadler