Skip to content

feat: Add STUN servers to enable P2P #1126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 25, 2022
Merged

feat: Add STUN servers to enable P2P #1126

merged 1 commit into from
Apr 25, 2022

Conversation

kylecarbs
Copy link
Member

This exposes a --stun-server option for listing
STUN servers. By default it uses the Google STUN
server, but this is not required.

@kylecarbs kylecarbs requested a review from coadler April 25, 2022 04:36
@kylecarbs kylecarbs self-assigned this Apr 25, 2022
@codecov
Copy link

codecov bot commented Apr 25, 2022

Codecov Report

Merging #1126 (d4d09ba) into main (8ff0c8b) will decrease coverage by 8.79%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1126      +/-   ##
==========================================
- Coverage   66.33%   57.53%   -8.80%     
==========================================
  Files         261      261              
  Lines       16203    16224      +21     
  Branches      156      156              
==========================================
- Hits        10748     9335    -1413     
- Misses       4344     5869    +1525     
+ Partials     1111     1020      -91     
Flag Coverage Δ
unittest-go-macos-latest 53.70% <100.00%> (-0.03%) ⬇️
unittest-go-postgres- ?
unittest-go-ubuntu-latest 56.33% <100.00%> (+0.05%) ⬆️
unittest-go-windows-2022 53.27% <100.00%> (+0.08%) ⬆️
unittest-js 67.28% <ø> (ø)
Impacted Files Coverage Δ
cli/gitssh.go 52.94% <ø> (ø)
cli/server.go 55.28% <100.00%> (-3.10%) ⬇️
coderd/database/queries.sql.go 0.00% <0.00%> (-81.80%) ⬇️
coderd/devtunnel/tunnel.go 0.00% <0.00%> (-79.67%) ⬇️
coderd/database/pubsub.go 0.00% <0.00%> (-77.78%) ⬇️
coderd/database/db.go 0.00% <0.00%> (-55.18%) ⬇️
coderd/database/migrate.go 0.00% <0.00%> (-45.00%) ⬇️
codersdk/provisionerdaemons.go 61.97% <0.00%> (-5.64%) ⬇️
cli/cliui/agent.go 77.19% <0.00%> (-5.27%) ⬇️
coderd/coderdtest/coderdtest.go 93.83% <0.00%> (-5.05%) ⬇️
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8ff0c8b...d4d09ba. Read the comment docs.

This exposes a `--stun-server` option for listing
STUN servers. By default it uses the Google STUN
server, but this is not required.
@kylecarbs kylecarbs enabled auto-merge (squash) April 25, 2022 04:48
@kylecarbs kylecarbs merged commit 4417dd5 into main Apr 25, 2022
@kylecarbs kylecarbs deleted the stun branch April 25, 2022 04:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants