feat: add light theme #11266
feat: add light theme #11266
Conversation
aslilac
commented
Dec 18, 2023
•
This comment was marked as resolved.
This comment was marked as resolved.
|
yeah, buttons have always had a shadow, it's just not very noticeable because of the dark background. I like the shadow a lot more than without, because otherwise you need a darker border which doesn't look very good imo. |
There was a problem hiding this comment.
I found a few more issues:
- The loading spinner in the workspace status badge and template editor build status badge are white.
- The contrast of the agent metadata is low
- The icon of the GitHub button is white
- The default icons in the app usage panel, on the template insights page are white
- The template source files theme colors have a low contrast
- The role badge, on the users page has a dark text on a dark background
- When a pagination item is active, it has a dark text on dark background
- The menu item on hover does not apply a different/contrast background
- The help tooltip links have a low contrast
- The rocket icon in the deployment bottom bar is white
|
Looking awesome! Some feedback: The contrast seems too light here
in comparison here's the contrast for the dark theme
Same with the create workspace button IMO
versus
in this case, it felt like I was "discovering" the button in the light mode (like where's waldo) where my eyes were drawn to it in the dark one Should this be red?
should this be green?
should this be red?
this blue is a bit jarring. perhaps if the "create workspace" was blue it wouldn't be
audit log diffs seem quite jarring too since the rest of ui has minimal constrast
|
|
Users Table |
|
I suggest we make the Green more greener. It will help improve the contrast for agent metadata and the health page. |
