chore: add agentapi tests #11269
Merged
chore: add agentapi tests #11269
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @deansheather and the rest of your teammates on |
spikecurtis
reviewed
Dec 19, 2023
spikecurtis
reviewed
Dec 20, 2023
| }, | ||
| } | ||
| } | ||
| ) |
There was a problem hiding this comment.
I wonder if we should break the manifest up into separate API calls. It's kind of a dumping ground for lots of different, unrelated kinds of information...
Not that I'm expecting it in this PR.
| now, err := time.Parse("2006-01-02 15:04:05 -0700 MST", "2023-12-19 07:30:00 +1100 AEDT") | ||
| require.NoError(t, err) | ||
| now = dbtime.Time(now) | ||
| nextAutostart := now.Add(30 * time.Minute).UTC() // always sent to DB as UTC |
There was a problem hiding this comment.
to me, this smells like we need to refactor. The AgentAPI should not be in the business of computing autostart times. There should be a scheduler component that gets an activity indication from the Agent API and it computes and decides how to update the autostart / autostop schedule.
Another one for some other PR...
spikecurtis
approved these changes
Jan 26, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The tests added in this PR can be reviewed now as I probably won't be changing them (other than review comments). I'll be adding more tests for the files TODOd below in upcoming commits and I'll re-request review.In most cases the new tests have more cases/coverage than the old ones which is nice. Some of them are quite verbose though, as I tried to maximize usage of fields on types and enums (to get conversion coverage).
TODOs:
metadata.gostats.gotailnet.go