Skip to content

feat: Add helper output on failed gitssh #1127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 25, 2022
Merged

feat: Add helper output on failed gitssh #1127

merged 1 commit into from
Apr 25, 2022

Conversation

kylecarbs
Copy link
Member

@kylecarbs kylecarbs commented Apr 25, 2022

This guides the user to adding their Coder keys
to GitHub/GitLab.

It outputs to stderr, so it doesn't interfere with
any Git operations.

Because this hooks with gitssh, once we add a disable
it won't appear anymore!

image

This is my first contribution from dogfooding v2 👀👀👀👀👀

@kylecarbs kylecarbs requested a review from coadler April 25, 2022 05:07
@kylecarbs kylecarbs self-assigned this Apr 25, 2022
@codecov
Copy link

codecov bot commented Apr 25, 2022

Codecov Report

Merging #1127 (477647c) into main (4417dd5) will decrease coverage by 0.08%.
The diff coverage is 33.33%.

@@            Coverage Diff             @@
##             main    #1127      +/-   ##
==========================================
- Coverage   66.42%   66.33%   -0.09%     
==========================================
  Files         261      261              
  Lines       16224    16237      +13     
  Branches      156      156              
==========================================
- Hits        10776    10771       -5     
- Misses       4340     4357      +17     
- Partials     1108     1109       +1     
Flag Coverage Δ
unittest-go-macos-latest 53.60% <33.33%> (-0.11%) ⬇️
unittest-go-postgres- 65.73% <33.33%> (-0.04%) ⬇️
unittest-go-ubuntu-latest 56.31% <33.33%> (-0.07%) ⬇️
unittest-go-windows-2022 53.28% <33.33%> (-0.03%) ⬇️
unittest-js 67.28% <ø> (ø)
Impacted Files Coverage Δ
codersdk/gitsshkey.go 50.00% <ø> (ø)
cli/gitssh.go 44.44% <20.00%> (-8.50%) ⬇️
cli/publickey.go 76.00% <100.00%> (ø)
coderd/gitsshkey.go 43.52% <100.00%> (+0.67%) ⬆️
peer/conn.go 77.41% <0.00%> (-4.57%) ⬇️
coderd/workspaceagents.go 59.62% <0.00%> (-2.97%) ⬇️
provisioner/terraform/provision.go 70.96% <0.00%> (-0.44%) ⬇️
coderd/provisionerdaemons.go 63.29% <0.00%> (+0.50%) ⬆️
provisionerd/provisionerd.go 76.94% <0.00%> (+0.93%) ⬆️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4417dd5...477647c. Read the comment docs.

This guides the user to adding their Coder keys
to GitHub/GitLab.

It outputs to stderr, so it doesn't interfere with
any Git operations.

Because this hooks with gitssh, once we add a disable
it won't appear anymore!
@kylecarbs kylecarbs requested a review from a team as a code owner April 25, 2022 05:17
@kylecarbs kylecarbs removed the request for review from a team April 25, 2022 05:19
@kylecarbs kylecarbs merged commit 7e33d80 into main Apr 25, 2022
@kylecarbs kylecarbs deleted the gitsshoutput branch April 25, 2022 05:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants