Skip to content

fix: add additional theme colors #11313

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Dec 21, 2023
Merged

fix: add additional theme colors #11313

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4f4e295
tada
aslilac Dec 21, 2023
f619cdb
small bits of cleanup, rebrand as "preview"
aslilac Dec 21, 2023
440db24
🧹
aslilac Dec 21, 2023
90b35ce
more comment tweaks
aslilac Dec 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
more comment tweaks
  • Loading branch information
@aslilac
aslilac committed Dec 21, 2023
commit 90b35ce3fba9d6a7e7b3489d53d3f21d8470fa2c
22 changes: 13 additions & 9 deletions site/src/theme/experimental.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,16 +11,13 @@ export interface NewTheme {
l2: InteractiveRole; // sidebars, table headers, navigation

roles: {
/** Deletion, immutable parameters, and things that have long lasting or irreversible effects */
danger: InteractiveRole;

/** Something went wrong; either unexpectedly, or in a meaningful way */
/** Something is wrong; either unexpectedly, or in a meaningful way. */
error: Role;

/** Something isn't quite right, but without serious consequence */
/** Something isn't quite right, but without serious consequence. */
warning: Role;

/** A prompt for action, to correct or look into something */
/** A prompt for action, to correct or look into something. */
notice: Role;

/** Notable information; just so you know! */
Expand All @@ -29,10 +26,17 @@ export interface NewTheme {
/** Confirmation, or affirming that things are as desired. */
success: InteractiveRole;

/** Selected, in progress, of particular relevance right now */
/** Selected, in progress, of particular relevance right now. */
active: InteractiveRole;

/** This isn't quite ready for prime-time, but you're welcome to look around! preview features, experiments, unstable etc. */
/** Actions that have long lasting or irreversible effects.
* Deletion, immutable parameters, etc.
*/
danger: InteractiveRole;

/** This isn't quite ready for prime-time, but you're welcome to look around!
* Preview features, experiments, unstable etc.
*/
preview: Role;
};
}
Expand All @@ -41,7 +45,7 @@ export interface NewTheme {
* ie. I wish to communicate an error, I wish to communicate that this is dangerous, etc.
*/
export interface Role {
/** A background color */
/** A background color that works best with the corresponding `outline` and `text` colors */
background: string;

/** A border, or a color for an outlined icon */
Expand Down