Skip to content

fix: fix name for external auth connections #11318

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 21, 2023
Merged

fix: fix name for external auth connections #11318

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e2ff709
fix: add a fallback icon for external auth connections
aslilac Dec 21, 2023
2c39ff4
nevermind
aslilac Dec 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
nevermind
  • Loading branch information
@aslilac
aslilac committed Dec 21, 2023
commit 2c39ff4bc0ad3b4e5bd13b19143a72ae00658b05
10 changes: 3 additions & 7 deletions site/src/pages/UserSettingsPage/ExternalAuthPage/ExternalAuthPageView.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,8 +27,6 @@ import {
import { ExternalAuth } from "pages/CreateWorkspacePage/ExternalAuth";
import { ExternalAuthPollingState } from "pages/CreateWorkspacePage/CreateWorkspacePage";

const FALLBACK_ICON = "/icon/widgets.svg";

export type ExternalAuthPageViewProps = {
isLoading: boolean;
getAuthsError?: unknown;
Expand Down Expand Up @@ -134,11 +132,9 @@ const ExternalAuthRow: FC<ExternalAuthRowProps> = ({
<AvatarData
title={name}
avatar={
<Avatar
src={app.display_icon || FALLBACK_ICON}
variant="square"
fitImage
/>
app.display_icon && (
<Avatar src={app.display_icon} variant="square" fitImage />
)
}
/>
</TableCell>
Expand Down