Skip to content

feat(site): refactor workspace header to be more slim #11327

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 21 commits into from
Jan 2, 2024

Conversation

BrunoQuaresma
Copy link
Collaborator

Current:

Screenshot 2023-12-22 at 08 46 03 Screenshot 2023-12-22 at 08 45 52

After:

Screenshot 2023-12-22 at 08 45 04 Screenshot 2023-12-22 at 08 44 48

@BrunoQuaresma BrunoQuaresma requested a review from a team December 22, 2023 13:37
@BrunoQuaresma BrunoQuaresma self-assigned this Dec 22, 2023
@BrunoQuaresma BrunoQuaresma requested review from Parkreiner and removed request for a team December 22, 2023 13:37
@BrunoQuaresma BrunoQuaresma changed the title feature(site): refactor workspace header to be more slim feat(site): refactor workspace header to be more slim Dec 22, 2023

if (parameters.queries) {
parameters.queries.forEach((query) => {
queryClient.setQueryData(query.key, query.data);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what are we doing here?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are setting the default values, passed via story parameters, for the react-query queries so the stories don't need to fetch the data. It is used to make the story independent of a BE or API.

},
) as typeof IconButton;

export const TopbarButton = forwardRef<HTMLButtonElement, ButtonProps>(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:) nice

@BrunoQuaresma BrunoQuaresma merged commit cf17fab into main Jan 2, 2024
@BrunoQuaresma BrunoQuaresma deleted the bq/implement-new-ws-header branch January 2, 2024 15:42
@github-actions github-actions bot locked and limited conversation to collaborators Jan 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants