Skip to content

chore(dogfood): update nodejs installation method #11339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Dec 26, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/dogfood.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ on:
workflow_dispatch:

jobs:
deploy_image:
build_image:
runs-on: buildjet-4vcpu-ubuntu-2204
steps:
- name: Checkout
Expand Down Expand Up @@ -53,7 +53,7 @@ jobs:
cache-to: type=inline

deploy_template:
needs: deploy_image
needs: build_image
if: github.ref == 'refs/heads/main'
runs-on: ubuntu-latest
steps:
Expand Down
1 change: 0 additions & 1 deletion dogfood/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -199,7 +199,6 @@ RUN LAZYGIT_VERSION=$(curl -s "https://api.github.com/repos/jesseduffield/lazygi
# Install frontend utilities
RUN apt-get update && \
# Node.js (from nodesource) and Yarn (from yarnpkg)
curl -fsSL https://deb.nodesource.com/setup_18.x | sudo -E bash - &&\
apt-get install --yes --quiet \
nodejs yarn \
# Install browsers for e2e testing
Expand Down
2 changes: 1 addition & 1 deletion dogfood/files/etc/apt/sources.list.d/nodesource.list
Original file line number Diff line number Diff line change
@@ -1 +1 @@
deb [signed-by=/usr/share/keyrings/nodesource.gpg] https://deb.nodesource.com/node_16.x jammy main
deb [signed-by=/usr/share/keyrings/nodesource.gpg] https://deb.nodesource.com/node_18.x nodistro main
Binary file modified dogfood/files/usr/share/keyrings/nodesource.gpg
Binary file not shown.