Skip to content

chore: add optional coder_app to faq #11351

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jan 11, 2024
Merged

chore: add optional coder_app to faq #11351

merged 5 commits into from
Jan 11, 2024

Conversation

sharkymark
Copy link
Contributor

This is PR:

Adds an FAQ entry showing how to make a coder_app resource optional and dependent on a coder_parameter

The use case is letting a user decide if they want a code-server browser IDE or not in a workspace.

Copy link
Member

@matifali matifali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few suggestions.

docs/faqs.md Outdated
Comment on lines 417 to 418
name = "code-server (optional)"
description = "Use VS Code in a browser"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
name = "code-server (optional)"
description = "Use VS Code in a browser"
name = "Do you want code-server in your workspace?"
description = "Use VS Code in a browser."

@github-actions github-actions bot added the stale This issue is like stale bread. label Jan 10, 2024
Copy link

github-actions bot commented Jan 11, 2024

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@stirby
Copy link
Collaborator

stirby commented Jan 11, 2024

I have read the CLA Document and I hereby sign the CLA

Copy link
Collaborator

@stirby stirby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

resolved atif's comments

@stirby stirby merged commit c91b885 into main Jan 11, 2024
@stirby stirby deleted the docs-faq-optional-coder-app branch January 11, 2024 18:07
@github-actions github-actions bot locked and limited conversation to collaborators Jan 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
stale This issue is like stale bread.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants