Skip to content

chore: disable failing metrics check until it can be fixed #11361

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 2, 2024
Merged

chore: disable failing metrics check until it can be fixed #11361

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
chore: disable failing metrics check until it can be fixed
  • Loading branch information
@spikecurtis
spikecurtis committed Jan 2, 2024
commit f3d8f028eb37c4e5189e52fe28e05c4d0d2ebba5
8 changes: 6 additions & 2 deletions scaletest/workspacetraffic/run_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,7 +139,9 @@ func TestRun(t *testing.T) {
t.Logf("bytes written total: %.0f\n", writeMetrics.Total())

// We want to ensure the metrics are somewhat accurate.
assert.InDelta(t, bytesPerTick, writeMetrics.Total(), 0.1)
// TODO: https://github.com/coder/coder/issues/11175
// assert.InDelta(t, bytesPerTick, writeMetrics.Total(), 0.1)

// Read is highly variable, depending on how far we read before stopping.
// Just ensure it's not zero.
assert.NotZero(t, readMetrics.Total())
Expand Down Expand Up @@ -259,7 +261,9 @@ func TestRun(t *testing.T) {
t.Logf("bytes written total: %.0f\n", writeMetrics.Total())

// We want to ensure the metrics are somewhat accurate.
assert.InDelta(t, bytesPerTick, writeMetrics.Total(), 0.1)
// TODO: https://github.com/coder/coder/issues/11175
// assert.InDelta(t, bytesPerTick, writeMetrics.Total(), 0.1)

// Read is highly variable, depending on how far we read before stopping.
// Just ensure it's not zero.
assert.NotZero(t, readMetrics.Total())
Expand Down