Skip to content

docs: update FE fetching data docs #11376

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jan 3, 2024
Merged

docs: update FE fetching data docs #11376

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
a0f96c8
docs(site): update fetching data docs
BrunoQuaresma Jan 2, 2024
e15c47a
Update workding with Michael suggestions
BrunoQuaresma Jan 2, 2024
47ffd42
update wording
BrunoQuaresma Jan 2, 2024
165e2a5
Update docs/contributing/frontend.md
BrunoQuaresma Jan 3, 2024
8d78545
Fix format
BrunoQuaresma Jan 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update docs/contributing/frontend.md 
Co-authored-by: Kira Pilot <kira@coder.com>
  • Loading branch information
@BrunoQuaresma @Kira-Pilot
BrunoQuaresma and Kira-Pilot authored Jan 3, 2024
commit 165e2a57c0f940c960c028012613d717263bf08f
4 changes: 1 addition & 3 deletions docs/contributing/frontend.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -271,9 +271,7 @@ another page, you should probably consider using the **E2E** approach.

### Visual testing

Test components without user interaction like testing if a page/component is
rendered correctly depending on some parameters, if the button is showing a
spinner, if the `loading` props are passing, etc. This should always be your
We use visual tests to test components without user interaction like testing if a page/component is rendered correctly depending on some parameters, if a button is showing a spinner, if `loading` props are passed correctly, etc. This should always be your
first option since it is way easier to maintain. For this, we use
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should always be your first option since it is way easier to maintain.

I disagree with this, tbh. I think we're running into difficulties when we use visual testing as our first line of defense. Maybe something we can chat about more during the FE variety call!

[Storybook](https://storybook.js.org/) and
[Chromatic](https://www.chromatic.com/).
Expand Down