Skip to content

fix(coderd/database): add missing v prefix to provisioner_daemons.api_version #11385

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 3, 2024
Merged

fix(coderd/database): add missing v prefix to provisioner_daemons.api_version #11385

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4bab3e8
fix(coderd/database): add missing v prefix to provisioner_daemons.api…
johnstcn Jan 3, 2024
be3bc7b
make gen
johnstcn Jan 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion coderd/database/dump.sql
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 5 additions & 0 deletions coderd/database/migrations/000183_provisionerd_api_version_prefix.down.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
ALTER TABLE ONLY provisioner_daemons
ALTER COLUMN api_version SET DEFAULT '1.0'::text;
UPDATE provisioner_daemons
SET api_version = '1.0'
WHERE api_version = 'v1.0';
5 changes: 5 additions & 0 deletions coderd/database/migrations/000183_provisionerd_api_version_prefix.up.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
ALTER TABLE ONLY provisioner_daemons
ALTER COLUMN api_version SET DEFAULT 'v1.0'::text;
UPDATE provisioner_daemons
SET api_version = 'v1.0'
WHERE api_version = '1.0';
2 changes: 1 addition & 1 deletion provisionersdk/serve.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ const (
// APIVersionCurrent is the current provisionerd API version.
// Breaking changes to the provisionerd API **MUST** increment
// the major version below.
APIVersionCurrent = "1.0"
APIVersionCurrent = "v1.0"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this is semver, should it be v1.0.0? Maybe this shorthand is allowed though.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

// The general form of a semantic version string accepted by this package is
//
//	vMAJOR[.MINOR[.PATCH[-PRERELEASE][+BUILD]]]
//
// where square brackets indicate optional parts of the syntax;

So shorthand is OK here.

)

// ServeOptions are configurations to serve a provisioner.
Expand Down