Skip to content

ci: broaden scope of needs.changes.db #11386

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 4, 2024
Merged

ci: broaden scope of needs.changes.db #11386

merged 3 commits into from
Jan 4, 2024

Conversation

johnstcn
Copy link
Member

@johnstcn johnstcn commented Jan 3, 2024 •
edited
Loading

#11381 made changes to coderd/database/dbfake.
Because test-go-pg got skipped, a test flake snuck onto main.
https://github.com/coder/coder/actions/runs/7395536966/job/20118913609

To prevent this from happening in future:

  • Broadening scope of needs.changes.db to include anything under the path coderd/database.
  • Removing dependency of test-go-pg on sqlc-vet.

@johnstcn johnstcn self-assigned this Jan 3, 2024
@johnstcn johnstcn requested a review from mafredri January 3, 2024 12:50
@johnstcn johnstcn enabled auto-merge (squash) January 3, 2024 12:56
@johnstcn johnstcn requested a review from Emyrk January 3, 2024 12:56
@johnstcn johnstcn disabled auto-merge January 3, 2024 12:56
@johnstcn johnstcn merged commit 4f433e7 into main Jan 4, 2024
@johnstcn johnstcn deleted the cj/github-ci-changes-db branch January 4, 2024 16:24
@github-actions github-actions bot locked and limited conversation to collaborators Jan 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Emyrk Emyrk Emyrk approved these changes

@mafredri mafredri Awaiting requested review from mafredri

Assignees

@johnstcn johnstcn

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@johnstcn @Emyrk