Skip to content

fix(site): fix loading spinner on template version status badge #11392

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 3, 2024
Merged

fix(site): fix loading spinner on template version status badge #11392

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 4 additions & 9 deletions site/src/pages/TemplateVersionEditorPage/TemplateVersionStatusBadge.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,8 @@
import { type TemplateVersion } from "api/typesGenerated";
import { type FC, type ReactNode } from "react";
import CircularProgress from "@mui/material/CircularProgress";
import ErrorIcon from "@mui/icons-material/ErrorOutline";
import CheckIcon from "@mui/icons-material/CheckOutlined";
import { Pill, type PillType } from "components/Pill/Pill";
import { Pill, PillSpinner, type PillType } from "components/Pill/Pill";

interface TemplateVersionStatusBadgeProps {
version: TemplateVersion;
Expand All @@ -20,10 +19,6 @@ export const TemplateVersionStatusBadge: FC<
);
};

const LoadingIcon: FC = () => {
return <CircularProgress size={10} style={{ color: "#FFF" }} />;
};

export const getStatus = (
version: TemplateVersion,
): {
Expand All @@ -36,19 +31,19 @@ export const getStatus = (
return {
type: "info",
text: "Running",
icon: <LoadingIcon />,
icon: <PillSpinner />,
};
case "pending":
return {
type: "info",
text: "Pending",
icon: <LoadingIcon />,
icon: <PillSpinner />,
};
case "canceling":
return {
type: "warning",
text: "Canceling",
icon: <LoadingIcon />,
icon: <PillSpinner />,
};
case "canceled":
return {
Expand Down