Skip to content

fix: send end of logs when dbfake completes job #11402

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 4, 2024

Conversation

spikecurtis
Copy link
Contributor

fixes #11389

Copy link
Contributor Author

Current dependencies on/for this PR:

This stack of pull requests is managed by Graphite.

Copy link
Member

@johnstcn johnstcn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice find. The fact that test-postgres was working fine should have been a signal to me about dbfake.

@spikecurtis
Copy link
Contributor Author

Nice find. The fact that test-postgres was working fine should have been a signal to me about dbfake.

It's not a postgres vs inmemory db issue. The old "dbfake" was renamed to "dbmem" and now "dbfake" is a package for creating fake data in a database (and works on dbmem and postgres).

It's just that provisionerdserver publishes logs and end of logs, and that's what the CLI uses to stop waiting for a build to complete. The race was between completing the job before we start watching logs (in which case we don't watch for logs at all and the test passes), vs watching logs first (in which case we never see end of logs and the cli hangs until the context is canceled).

@spikecurtis spikecurtis merged commit f9ebe8c into main Jan 4, 2024
@spikecurtis spikecurtis deleted the spike/11389-starting-flake branch January 4, 2024 11:18
@github-actions github-actions bot locked and limited conversation to collaborators Jan 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

test flake: TestStart_Starting
2 participants