-
Notifications
You must be signed in to change notification settings - Fork 887
chore: Add Contributors section to readme #1144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1144 +/- ##
==========================================
- Coverage 66.26% 65.99% -0.27%
==========================================
Files 265 261 -4
Lines 16682 16482 -200
Branches 157 157
==========================================
- Hits 11054 10877 -177
+ Misses 4483 4470 -13
+ Partials 1145 1135 -10
Continue to review full report at Codecov.
|
I wonder if this could be autogenned? I've seen that on other repos before, but I'm having trouble finding them! |
@kylecarbs I like that idea! I've seen things like actions/contributors-list which displays the users picture/name. Are we ok with utilizing GitHub Actions for this? And do we want to include the extended information like first PR date and organization? The former may be queryable via GitHub API (need to verify), but as for the latter the user could be part of multiple organizations. |
b9f5be3
to
975cdbe
Compare
Co-authored-by: Cian Johnston <public@cianjohnston.ie>
@mafredri I was thinking we'd use something like: https://contrib.rocks/preview?repo=coder%2Fcode-server |
Ah, that's actually a pretty nice solution to avoid having to re-generate the README. I suppose we would need a self-hosted solution to access the private repo? One downside with the image version is that you can't click to the users profile (if we consider that important). |
That's true. I'd be in favor of using contributors-list in that case, I'm concerned that the manually maintained list will not be manually maintained 😁 |
Co-authored-by: Cian Johnston <public@cianjohnston.ie>
This PR adds a Contributors-section to the readme as described in #1112. Additionally the date format was explicitly documented.
Subtasks (as part of my onboarding)
Fixes #1112