chore(dogfood): update dogfood template to use artifactory #11452
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matifali
commented
Jan 5, 2024
dogfood/main.tf
Outdated
| keep_locally = true | ||
| name = "${local.jfrog_host}/docker/${local.registry_name}:latest" | ||
| pull_triggers = [null_resource.update_trigger.id] | ||
| keep_locally = true | ||
| } |
There was a problem hiding this comment.
This was not working nicely with a private docker registry, so I had to resort to this hack,
I filed an issue with the docker provider.
kreuzwerker/terraform-provider-docker#593
There was a problem hiding this comment.
This is also not working, and terraform is not pulling the latest image even though Artifactory has it.
There are open issues regarding this: kreuzwerker/terraform-provider-docker#172
There was a problem hiding this comment.
We can skip pulling from the satisfactory in Terraform or use a new tag on each build. Probably short git sha.
There was a problem hiding this comment.
After talking to @Emyrk, we decided not to use Artifactory to fetch pull docker image.
Emyrk
approved these changes
Jan 5, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request updates the dogfood template to configure
npm,pip,goanddockerto fetch packages from the Artifactory. This also installs the JFrog extension in code-server.