Skip to content

test: Wait for WorkspaceResources to complete before exiting #1149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 25, 2022
Merged

test: Wait for WorkspaceResources to complete before exiting #1149

merged 1 commit into from
Apr 25, 2022

Conversation

kylecarbs
Copy link
Member

@kylecarbs kylecarbs requested a review from coadler April 25, 2022 18:04
@kylecarbs kylecarbs self-assigned this Apr 25, 2022
@kylecarbs kylecarbs enabled auto-merge (squash) April 25, 2022 18:05
@codecov
Copy link

codecov bot commented Apr 25, 2022 •
edited
Loading

Codecov Report

Merging #1149 (ad69c0b) into main (1e6f2cf) will increase coverage by 0.46%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1149      +/-   ##
==========================================
+ Coverage   65.86%   66.32%   +0.46%     
==========================================
  Files         255      257       +2     
  Lines       16034    16055      +21     
  Branches      156      156              
==========================================
+ Hits        10561    10649      +88     
+ Misses       4357     4313      -44     
+ Partials     1116     1093      -23
Flag Coverage Δ
unittest-go-macos-latest 53.80% <ø> (?)
unittest-go-postgres- 65.74% <ø> (+0.01%) ⬆️
unittest-go-ubuntu-latest 56.36% <ø> (?)
unittest-js 67.28% <ø> (ø)
Impacted Files Coverage Δ
coderd/provisionerdaemons.go 62.79% <0.00%> (-0.51%) ⬇️
agent/usershell/usershell_darwin.go 100.00% <0.00%> (ø)
cli/cliui/cliui_darwin.go 0.00% <0.00%> (ø)
provisionerd/provisionerd.go 75.70% <0.00%> (+0.53%) ⬆️
peer/channel.go 83.81% <0.00%> (+0.57%) ⬆️
peerbroker/proxy.go 58.72% <0.00%> (+0.58%) ⬆️
coderd/users.go 60.36% <0.00%> (+1.46%) ⬆️
coderd/templateversions.go 58.99% <0.00%> (+2.15%) ⬆️
coderd/parameters.go 62.50% <0.00%> (+2.20%) ⬆️
provisioner/echo/serve.go 56.80% <0.00%> (+2.39%) ⬆️
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1e6f2cf...ad69c0b. Read the comment docs.

@kylecarbs kylecarbs merged commit 09405dd into main Apr 25, 2022
@kylecarbs kylecarbs deleted the resourceflake branch April 25, 2022 18:11
kylecarbs added a commit that referenced this pull request Jun 10, 2022
@kylecarbs
test: Wait for WorkspaceResources to complete before exiting (#1149)
32cdf0d 
This caused a flake seen in:
https://github.com/coder/coder/runs/6162655678?check_suite_focus=true#step:9:87
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coadler coadler coadler approved these changes

Assignees

@kylecarbs kylecarbs

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kylecarbs @coadler