feat(site): add healthcheck page for provisioner daemons #11494
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
mtojek
reviewed
Jan 8, 2024
| import { ProvisionerDaemonsPage } from "./ProvisionerDaemonsPage"; | ||
| import { generateMeta } from "./storybook"; | ||
|
|
||
| const meta: Meta = { |
There was a problem hiding this comment.
Should we also add other stories to cover different conditions of this UI view?
There was a problem hiding this comment.
Yeah, we need to do this for essentially all of the provisionerd healthchecks. I think this can be resolved in #10785
|
Also, you may want to place the UI screenshot in the PR description :) |
BrunoQuaresma
approved these changes
Jan 8, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #10676
Storybook screenshot: