Skip to content

fix: Disable known hosts checking for config-ssh #1150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 25, 2022
Merged

fix: Disable known hosts checking for config-ssh #1150

merged 1 commit into from
Apr 25, 2022

Conversation

kylecarbs
Copy link
Member

This was causing the remote identity changed message.
We don't need to verify remote hosts because we
already auth via our API.

@kylecarbs kylecarbs requested a review from coadler April 25, 2022 18:33
@kylecarbs kylecarbs self-assigned this Apr 25, 2022
@kylecarbs kylecarbs enabled auto-merge (squash) April 25, 2022 18:36
@codecov
Copy link

codecov bot commented Apr 25, 2022 •
edited
Loading

Codecov Report

Merging #1150 (ecc8588) into main (a2dd618) will increase coverage by 0.17%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1150      +/-   ##
==========================================
+ Coverage   66.24%   66.41%   +0.17%     
==========================================
  Files         255      261       +6     
  Lines       16120    16340     +220     
  Branches      156      156              
==========================================
+ Hits        10678    10852     +174     
- Misses       4335     4371      +36     
- Partials     1107     1117      +10
Flag Coverage Δ
unittest-go-macos-latest 53.75% <100.00%> (?)
unittest-go-postgres- 65.78% <100.00%> (+0.13%) ⬆️
unittest-go-ubuntu-latest 56.28% <100.00%> (-0.07%) ⬇️
unittest-go-windows-2022 53.30% <100.00%> (?)
unittest-js 67.28% <ø> (ø)
Impacted Files Coverage Δ
cli/configssh.go 69.23% <100.00%> (+7.81%) ⬆️
provisionersdk/serve.go 35.13% <0.00%> (-8.11%) ⬇️
codersdk/provisionerdaemons.go 61.97% <0.00%> (-5.64%) ⬇️
provisionerd/provisionerd.go 75.83% <0.00%> (-0.67%) ⬇️
provisioner/echo/serve.go 56.80% <0.00%> (ø)
agent/usershell/usershell_darwin.go 100.00% <0.00%> (ø)
agent/usershell/usershell_windows.go 83.33% <0.00%> (ø)
pty/pty_windows.go 68.25% <0.00%> (ø)
cli/ssh_windows.go 0.00% <0.00%> (ø)
cli/cliui/cliui_darwin.go 0.00% <0.00%> (ø)
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a2dd618...ecc8588. Read the comment docs.

@kylecarbs
fix: Disable known hosts checking for config-ssh
ecc8588 
This was causing the remote identity changed message.
We don't need to verify remote hosts because we
already auth via our API.
@kylecarbs kylecarbs merged commit 9056c53 into main Apr 25, 2022
@kylecarbs kylecarbs deleted the noknownhosts branch April 25, 2022 18:59
kylecarbs added a commit that referenced this pull request Jun 10, 2022
@kylecarbs
fix: Disable known hosts checking for config-ssh (#1150)
8da37f2 
This was causing the remote identity changed message.
We don't need to verify remote hosts because we
already auth via our API.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coadler coadler coadler approved these changes

Assignees

@kylecarbs kylecarbs

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kylecarbs @coadler