Skip to content

feat: display application name over sign in form #11500

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 9, 2024
Merged

Conversation

f0ssel
Copy link
Contributor

@f0ssel f0ssel commented Jan 8, 2024

Closes #11345

Before:
Screenshot 2024-01-08 at 12 50 54 PM

After:
Screenshot 2024-01-08 at 12 51 08 PM
Screenshot 2024-01-08 at 1 02 17 PM

Copy link
Collaborator

@BrunoQuaresma BrunoQuaresma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not very comfortable with this change but maybe I'm nitpicking a bit. I never saw any other platform having the company name only on the sign-in page but if you feel we should do that we can give it a try.

@f0ssel
Copy link
Contributor Author

f0ssel commented Jan 9, 2024

I gave the customer the benefit of the doubt because we have the "Sign In" button at the end of the form. I'm not married to this solution and think we can iterate. My goal is to make the Application Name feature function the way customers expect it to - by displaying it in some way on the login screen. Thanks for the feedback and feel free to suggest future changes.

@f0ssel f0ssel merged commit 4fa0712 into main Jan 9, 2024
@f0ssel f0ssel deleted the f0ssel/sign-in-name branch January 9, 2024 17:51
@github-actions github-actions bot locked and limited conversation to collaborators Jan 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: Logo URL in Appearance dashboard does not explain that it also updates the logo on the Sign In page
2 participants