Skip to content

test: Loop if content length is zero for Windows #1151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 25, 2022
Merged

test: Loop if content length is zero for Windows #1151

merged 1 commit into from
Apr 25, 2022

Conversation

kylecarbs
Copy link
Member

On Windows it seems the file can be created before the
content has been written, which results in comparing
an empty string.

@kylecarbs
test: Loop if content length is zero for Windows
6725585 
On Windows it seems the file can be created before the
content has been written, which results in comparing
an empty string.
@kylecarbs kylecarbs requested a review from coadler April 25, 2022 18:47
@kylecarbs kylecarbs self-assigned this Apr 25, 2022
@kylecarbs kylecarbs enabled auto-merge (squash) April 25, 2022 18:48
@codecov
Copy link

codecov bot commented Apr 25, 2022 •
edited
Loading

Codecov Report

Merging #1151 (6725585) into main (a2dd618) will increase coverage by 0.16%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1151      +/-   ##
==========================================
+ Coverage   66.24%   66.40%   +0.16%     
==========================================
  Files         255      261       +6     
  Lines       16120    16337     +217     
  Branches      156      156              
==========================================
+ Hits        10678    10849     +171     
- Misses       4335     4371      +36     
- Partials     1107     1117      +10
Flag Coverage Δ
unittest-go-macos-latest 53.73% <ø> (?)
unittest-go-postgres- 65.67% <ø> (+0.03%) ⬆️
unittest-go-ubuntu-latest 56.33% <ø> (-0.02%) ⬇️
unittest-go-windows-2022 53.29% <ø> (?)
unittest-js 67.28% <ø> (ø)
Impacted Files Coverage Δ
codersdk/provisionerdaemons.go 61.97% <0.00%> (-5.64%) ⬇️
provisioner/echo/serve.go 54.40% <0.00%> (-2.40%) ⬇️
provisionerd/provisionerd.go 76.23% <0.00%> (-0.27%) ⬇️
cli/ssh_windows.go 0.00% <0.00%> (ø)
cli/cliui/cliui_darwin.go 0.00% <0.00%> (ø)
agent/usershell/usershell_darwin.go 100.00% <0.00%> (ø)
pty/start_windows.go 66.95% <0.00%> (ø)
agent/usershell/usershell_windows.go 83.33% <0.00%> (ø)
pty/pty_windows.go 68.25% <0.00%> (ø)
provisioner/terraform/provision.go 71.39% <0.00%> (+0.43%) ⬆️
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a2dd618...6725585. Read the comment docs.

@kylecarbs kylecarbs merged commit 6434888 into main Apr 25, 2022
@kylecarbs kylecarbs deleted the fixstartup branch April 25, 2022 19:01
kylecarbs added a commit that referenced this pull request Jun 10, 2022
@kylecarbs
test: Loop if content length is zero for Windows (#1151)
e58080f 
On Windows it seems the file can be created before the
content has been written, which results in comparing
an empty string.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coadler coadler coadler approved these changes

Assignees

@kylecarbs kylecarbs

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kylecarbs @coadler