Skip to content

fix: switch node version to v18 in nix #11510

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 9, 2024
Merged

fix: switch node version to v18 in nix #11510

merged 1 commit into from
Jan 9, 2024

Conversation

mtojek
Copy link
Member

@mtojek mtojek commented Jan 9, 2024

I was unable to build coder site locally:

 ERR_PNPM_UNSUPPORTED_ENGINE  Unsupported environment (bad pnpm and/or Node.js version)

Your Node version is incompatible with "/Users/mtojek/code/coder/site".

Expected version: >=18.0.0 <19.0.0
Got: v20.10.0

This is happening because the package's manifest has an engines.node field specified.
To fix this issue, install the required Node version.
make: *** [Makefile:363: site/out/index.html] Error 1

We need to force nix to use expect node version.

@mtojek mtojek self-assigned this Jan 9, 2024
@mtojek mtojek changed the title fix: nix: force node version v18 fix: switch node version to v18 in nix Jan 9, 2024
@mtojek mtojek requested review from mafredri and matifali January 9, 2024 11:23
@mtojek mtojek marked this pull request as ready for review January 9, 2024 11:23
@mtojek mtojek merged commit b8373e6 into main Jan 9, 2024
@mtojek mtojek deleted the fix-nix-node branch January 9, 2024 11:27
@github-actions github-actions bot locked and limited conversation to collaborators Jan 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mafredri mafredri mafredri approved these changes

@matifali matifali Awaiting requested review from matifali

Assignees

@mtojek mtojek

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mtojek @mafredri