Skip to content

fix(coderd/healthcheck): ignore deleted wsproxies in wsproxy healthcheck #11515

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 9, 2024
Merged

fix(coderd/healthcheck): ignore deleted wsproxies in wsproxy healthcheck #11515

merged 2 commits into from
Jan 9, 2024

Conversation

johnstcn
Copy link
Member

@johnstcn johnstcn commented Jan 9, 2024

Fixes #11440

@johnstcn johnstcn self-assigned this Jan 9, 2024
@johnstcn johnstcn requested a review from mtojek January 9, 2024 15:58
mtojek
mtojek approved these changes Jan 9, 2024
View reviewed changes
Copy link
Member

@mtojek mtojek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@johnstcn johnstcn merged commit 9f4f953 into main Jan 9, 2024
@johnstcn johnstcn deleted the cj/healthcheck-wsproxy-ignore-deleted branch January 9, 2024 16:36
@github-actions github-actions bot locked and limited conversation to collaborators Jan 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mtojek mtojek mtojek approved these changes

Assignees

@johnstcn johnstcn

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

coderd: do not show deleted wsproxies
2 participants
@johnstcn @mtojek