Skip to content

chore: instrument external oauth2 requests #11519

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 20 commits into from
Jan 10, 2024
Merged

chore: instrument external oauth2 requests #11519

Changes from 1 commit
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
b7f13fa
chore: instrument external oauth2 requests
Emyrk Jan 9, 2024
fd1e012
Add a unit test
Emyrk Jan 9, 2024
a6de1e3
remove internet based request
Emyrk Jan 9, 2024
005883a
use ctx
Emyrk Jan 9, 2024
2f77f99
typo
Emyrk Jan 9, 2024
3377a9b
Work on instrumenting related oauth2 calls
Emyrk Jan 9, 2024
07fd10d
remove print
Emyrk Jan 9, 2024
117a405
typos
Emyrk Jan 9, 2024
73abae6
Fixup some unit tests
Emyrk Jan 9, 2024
e5e190d
fixup test cases
Emyrk Jan 9, 2024
d4b36d3
remove oidc instrument
Emyrk Jan 9, 2024
8964297
typos
Emyrk Jan 9, 2024
2ba7a5c
more test coverage
Emyrk Jan 9, 2024
8963aaa
left debug
Emyrk Jan 9, 2024
bfa427f
Add comments
Emyrk Jan 9, 2024
9d1c76c
use consts for source labels
Emyrk Jan 10, 2024
c149f8f
Spell out config
Emyrk Jan 10, 2024
30c459f
fix compile
Emyrk Jan 10, 2024
cd98806
Use req with context
Emyrk Jan 10, 2024
85e2d91
no panic
Emyrk Jan 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
use ctx
  • Loading branch information
@Emyrk
Emyrk committed Jan 10, 2024
commit 005883a439cc9d9ab85185bc0c1a6208775d4ed2
1 change: 1 addition & 0 deletions coderd/promoauth/oauth2_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,7 @@ func TestMaintainDefault(t *testing.T) {
req, err := http.NewRequest(http.MethodGet,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor suggestion: Could use httptest.NewRequest to avoid checking error. Alternatively http.NewRequestWithContext to skip that step.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

httptest just uses panics instead of an error 🤷
https://github.com/golang/go/blob/master/src/net/http/httptest/httptest.go#L46

I can use NewRequestWithContext though

must(idp.IssuerURL().Parse("/.well-known/openid-configuration")).String(), nil)
require.NoError(t, err)
req = req.WithContext(ctx)

resp, err := http.DefaultClient.Do(req)
require.NoError(t, err)
Expand Down