Skip to content

feat: add additional fields to first time setup trial flow #11533

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 17, 2024

Conversation

coadler
Copy link
Contributor

@coadler coadler commented Jan 9, 2024

Adds additional fields in the setup page when a trial is selected. This is meant as a temporary solution until a full page can be built out.

image.png

@coadler
Copy link
Contributor Author

coadler commented Jan 9, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @coadler and the rest of your teammates on Graphite Graphite

@coadler coadler force-pushed the colin/feataddadditionalfieldstofirsttimesetuptrialflow branch 8 times, most recently from 8f3f22c to ad0ba95 Compare January 10, 2024 01:15
@coadler coadler force-pushed the colin/feataddadditionalfieldstofirsttimesetuptrialflow branch from ad0ba95 to f9eca5a Compare January 12, 2024 18:49
@@ -410,7 +410,7 @@ export const components = {
root: {
// Not sure why but since the input has padding we don't need it here
"& .MuiInputBase-root": {
padding: 0,
padding: "0px 0px 0px 8px",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is what fixed the zero padding in the country autocomplete field. I looked at other autocomplete boxes and it doesn't seem to affect them at all.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We probably just want to apply this style in the specific country component right? This can break other components.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@BrunoQuaresma I tried to do something like you did here but couldn't get it to work since my Autocomplete component wouldn't accept InputProps, only inputProps, which didn't seem to work.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see, if it does not break other autocomplete components like the user/groups in the groups page I'm ok with that

@coadler coadler marked this pull request as ready for review January 12, 2024 18:58
Comment on lines +216 to +229
<TextField
{...getFieldHelpers("trial_info.first_name")}
id="trial_info.first_name"
name="trial_info.first_name"
fullWidth
label={Language.firstNameLabel}
/>
<TextField
{...getFieldHelpers("trial_info.last_name")}
id="trial_info.last_name"
name="trial_info.last_name"
fullWidth
label={Language.lastNameLabel}
/>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I unfortunately don't really have a choice re: the single Name input, since this is the info they need in Hubspot. Can probably be revisited when this is refactored into a new page.

Copy link
Collaborator

@BrunoQuaresma BrunoQuaresma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FE code looks good 👍 Just one minor observation

@coadler coadler merged commit be43d62 into main Jan 17, 2024
@coadler coadler deleted the colin/feataddadditionalfieldstofirsttimesetuptrialflow branch January 17, 2024 00:19
@github-actions github-actions bot locked and limited conversation to collaborators Jan 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants