-
Notifications
You must be signed in to change notification settings - Fork 887
feat: add additional fields to first time setup trial flow #11533
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add additional fields to first time setup trial flow #11533
Conversation
This stack of pull requests is managed by Graphite. Learn more about stacking. |
8f3f22c
to
ad0ba95
Compare
ad0ba95
to
f9eca5a
Compare
@@ -410,7 +410,7 @@ export const components = { | |||
root: { | |||
// Not sure why but since the input has padding we don't need it here | |||
"& .MuiInputBase-root": { | |||
padding: 0, | |||
padding: "0px 0px 0px 8px", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is what fixed the zero padding in the country autocomplete field. I looked at other autocomplete boxes and it doesn't seem to affect them at all.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We probably just want to apply this style in the specific country component right? This can break other components.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@BrunoQuaresma I tried to do something like you did here but couldn't get it to work since my Autocomplete
component wouldn't accept InputProps
, only inputProps
, which didn't seem to work.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see, if it does not break other autocomplete components like the user/groups in the groups page I'm ok with that
<TextField | ||
{...getFieldHelpers("trial_info.first_name")} | ||
id="trial_info.first_name" | ||
name="trial_info.first_name" | ||
fullWidth | ||
label={Language.firstNameLabel} | ||
/> | ||
<TextField | ||
{...getFieldHelpers("trial_info.last_name")} | ||
id="trial_info.last_name" | ||
name="trial_info.last_name" | ||
fullWidth | ||
label={Language.lastNameLabel} | ||
/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I unfortunately don't really have a choice re: the single Name
input, since this is the info they need in Hubspot. Can probably be revisited when this is refactored into a new page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FE code looks good 👍 Just one minor observation
Adds additional fields in the setup page when a trial is selected. This is meant as a temporary solution until a full page can be built out.